----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28667/#review63760 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Dec. 3, 2014, 7:53 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28667/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 7:53 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Now that the allocator is no longer embedded in the master, this makes the > method naming more idiomatic by avoiding past tense. > > > Diffs > ----- > > src/master/allocator.hpp 02d20d0cc802805bc702891306aa42894531b223 > src/master/hierarchical_allocator_process.hpp > fbaa23fad37fc6cbe870932cd4ace6622080001b > src/master/master.cpp c840d497d9486cde970b11ba79e12feb15ee9ccf > src/tests/allocator_tests.cpp 1fcbb4a4c7ada2b88443c635b76c294848ac13d8 > src/tests/fault_tolerance_tests.cpp > 5baeda6e4811905648b13898a46655caedd647c3 > src/tests/master_authorization_tests.cpp > 796fe21c7936aaeef86a38984dcc6e455e92784b > src/tests/master_tests.cpp 065fc3e055f16949f8462779cdd1f410fa1ea59a > src/tests/mesos.hpp f132c6caff471ce1be069f31eadb1d7e5d0f7dfd > src/tests/partition_tests.cpp 0dc1a92ec2c2be9aac7a6c6d158d4a907421473a > src/tests/rate_limiting_tests.cpp e1fd3c2f0f5057473364e8bca340fb7874eb252a > src/tests/resource_offers_tests.cpp > 7e09319727992505b0b98af0943f9541c5d182e2 > src/tests/slave_recovery_tests.cpp 2b6c76af704b3b02da27fe463b3e52086d2d106a > > Diff: https://reviews.apache.org/r/28667/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >