> On Nov. 20, 2014, 10:26 a.m., Niklas Nielsen wrote: > > src/Makefile.am, line 292 > > <https://reviews.apache.org/r/28065/diff/2/?file=765853#file765853line292> > > > > s/grace/graceful/? If so, then do a scan over the files. > > Alexander Rukletsov wrote: > I think it makes sense to be consistent. We agreed for "grace_shutdown" > for the proto message. However, I'm not a native speaker. I remember BenM > used "grace shutdown" in replies on the dev list.
It is called grace_period in the proto. I agree, that shouldn't be called 'graceful period' - but 'grace shutdown' doesn't describe what it does. Still root for 'graceful shotdown' > On Nov. 20, 2014, 10:26 a.m., Niklas Nielsen wrote: > > src/slave/grace_shutdown.hpp, line 37 > > <https://reviews.apache.org/r/28065/diff/2/?file=765856#file765856line37> > > > > /<-- shutdown_grace_period/<-- shutdown_grace_period./ > > Alexander Rukletsov wrote: > It's `flags.shutdown_grace_period` wrapped and indented by 2 spaces. Or > that is not your point? Oh - that is confusing. Why two arrows then? - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28065/#review62291 ----------------------------------------------------------- On Nov. 24, 2014, 9:13 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28065/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 9:13 a.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > Shutdown grace period differs across shutdown levels (containerizer, > ExecutorProcess, CommandExecutor). Each nested timeout is somewhat shorter > than the parent one. > > > Diffs > ----- > > src/Makefile.am 2448db8 > src/slave/constants.hpp fd1c1ab > src/slave/constants.cpp 2a99b11 > src/slave/grace_shutdown.hpp PRE-CREATION > src/slave/grace_shutdown.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28065/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.4, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
