----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28684/#review63791 -----------------------------------------------------------
Ship it! Thanks jie! Make sure to update all the comments per my suggestions below. src/master/master.cpp <https://reviews.apache.org/r/28684/#comment106093> Visitor pattern no longer relevant. src/master/master.cpp <https://reviews.apache.org/r/28684/#comment106092> This note about typedef is no longer true. src/master/master.cpp <https://reviews.apache.org/r/28684/#comment106097> Let's also do s/task description/task/ src/master/master.cpp <https://reviews.apache.org/r/28684/#comment106096> s/Checks/Validates/ here and in all cases above. src/master/master.cpp <https://reviews.apache.org/r/28684/#comment106095> Hm.. could we just use std::array? Looks like it is included in 4.4: https://gcc.gnu.org/ml/libstdc++/2010-03/msg00046.html Ditto for task validators. src/master/master.cpp <https://reviews.apache.org/r/28684/#comment106094> s/checkers/validators/ - Ben Mahler On Dec. 4, 2014, 12:45 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28684/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 12:45 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Renamed task and offer visitors to validators. > > > Diffs > ----- > > src/master/master.hpp e6ed87da8bbe56ce693547c227149312ba24f457 > src/master/master.cpp 3dc4e7a64bb28ab111fe6ed71eb87064f416acfd > > Diff: https://reviews.apache.org/r/28684/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
