----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28681/#review63842 -----------------------------------------------------------
Ship it! LGTM, just wondering about inclusive/exclusive [0,1] vs. (0,1) src/slave/slave.cpp <https://reviews.apache.org/r/28681/#comment106146> Can it even be ==0 or ==1? - Adam B On Dec. 3, 2014, 4:29 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28681/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 4:29 p.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-2169 > https://issues.apache.org/jira/browse/MESOS-2169 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/flags.hpp 4f5b8b405925a41b8b6961fd25d7ff6e8699fa68 > src/slave/slave.cpp 9ac64589c353b2f17f538db7de01faa55b2369b9 > > Diff: https://reviews.apache.org/r/28681/diff/ > > > Testing > ------- > > make check and functional testing. > > > Thanks, > > Niklas Nielsen > >
