----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28321/#review63886 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/configure.ac <https://reviews.apache.org/r/28321/#comment106228> Indent +2 please. 3rdparty/libprocess/configure.ac <https://reviews.apache.org/r/28321/#comment106229> See comment in other review about error message please. 3rdparty/libprocess/src/libevent.hpp <https://reviews.apache.org/r/28321/#comment106230> Can we add a comment explaining what this is just as we did in libev.hpp? 3rdparty/libprocess/src/libevent.cpp <https://reviews.apache.org/r/28321/#comment106199> s/void */void* / 3rdparty/libprocess/src/libevent.cpp <https://reviews.apache.org/r/28321/#comment106200> Can you elaborate on this comment with a complete sentence? Or just remove this line? 3rdparty/libprocess/src/libevent.cpp <https://reviews.apache.org/r/28321/#comment106201> Did you mean s/event_base/event_base_new/ here? - Benjamin Hindman On Dec. 4, 2014, 12:19 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28321/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 12:19 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204 > 3rdparty/libprocess/src/libevent.hpp PRE-CREATION > 3rdparty/libprocess/src/libevent.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 > > Diff: https://reviews.apache.org/r/28321/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
