> On Dec. 15, 2014, 1:47 p.m., Dominic Hamon wrote: > > include/mesos/resources.hpp, line 213 > > <https://reviews.apache.org/r/29018/diff/1/?file=791218#file791218line213> > > > > not quite. emplace_back with a unique_ptr works because unique_ptr > > doesn't have a copy constructor. however, as it turns out, both > > push_back(std::move(..)) and emplace_back(..) may leak if the vector grow > > fails and an exception is thrown. > > > > ideally, then, this should be push_back(make_unique<>(..)) > > > > but we don't have make_unique ;) > > Michael Park wrote: > Hey Dominic, was this supposed to be a reply to my comment?
yes, sorry. i forgot that it doesn't thread correctly from the diff. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29018/#review65125 ----------------------------------------------------------- On Dec. 12, 2014, 9:57 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29018/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 9:57 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2030 > https://issues.apache.org/jira/browse/MESOS-2030 > > > Repository: mesos-git > > > Description > ------- > > Added abstraction for resources transformation. Split from > https://reviews.apache.org/r/28720/. > > > Diffs > ----- > > include/mesos/resources.hpp 296553af93ec8457dad04ac018f03f36df654fdc > src/common/resources.cpp 9bf7ae9148d6db2829cc2866ac048fe018ae2c92 > > Diff: https://reviews.apache.org/r/29018/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
