----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28966/#review65213 -----------------------------------------------------------
src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/28966/#comment108243> this can be a const method as you don't change any members. - Dominic Hamon On Dec. 15, 2014, 5:54 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28966/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2014, 5:54 p.m.) > > > Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > also added a test. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp f1e2352 > src/slave/containerizer/isolators/network/port_mapping.cpp 2d81336 > src/tests/port_mapping_tests.cpp eb82993 > > Diff: https://reviews.apache.org/r/28966/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Chi Zhang > >
