----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29083/#review65394 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Dec. 17, 2014, 11:20 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29083/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 11:20 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-2099 > https://issues.apache.org/jira/browse/MESOS-2099 > > > Repository: mesos-git > > > Description > ------- > > In order for frameworks to perform resource transformations on their > allocations, the allocator must be able to update the allocation in the > sorter objects. > > Note that the sorters cannot simply take a Transformation, as done in > r/29084/. This is because sorters may not store the complete allocation for a > client (e.g. role sorter doesn't track reserved resources). > > This means that taking a Transformation is problematic for the role sorter in > the allocator. > > > Diffs > ----- > > src/master/drf_sorter.hpp c47b56afdb8f9f3ff0793f0d10a4e4c656e6a212 > src/master/drf_sorter.cpp ebc0284170750ee3860e89931a96a2330c795fbe > src/master/sorter.hpp 0150f90b9aab2ecb4edd07dca7f0d58997e422aa > src/tests/sorter_tests.cpp c2f4aa18db986d12d8364fe5ca3c0dc1b8f98040 > > Diff: https://reviews.apache.org/r/29083/diff/ > > > Testing > ------- > > Added a test. > > > Thanks, > > Ben Mahler > >
