> On Dec. 19, 2014, 11:21 p.m., Adam B wrote: > > Looks great! Just a few more comments/log messages to reword.
Thanks a bunch for taking care of the proper wording, much appreciated! > On Dec. 19, 2014, 11:21 p.m., Adam B wrote: > > src/master/master.cpp, lines 3980-3981 > > <https://reviews.apache.org/r/27760/diff/7-8/?file=766650#file766650line3980> > > > > We use @param in at least a couple of src/linux/ c++ files, and may do > > more with doxygen in the future, so how about: > > `// @param from The authenticatee process with which to communicate.` > > `// @param pid The framework/slave process being authenticated.` > > Ben Mahler wrote: > Hm.. sounds like poor naming if this is needed. How about renaming these > variables to avoid the need for the comment: > > s/from/authenticatee/ > > s/pid/client/ Ben, I think you are right - the nameing is definitely questionable. On the other hand however, we commonly stick to the parameter name from the message definition and that is indeed "pid". Introducing doxygen formatted function headers IMHO is a great thing and hence I will go with Adam's suggestion for now. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review65703 ----------------------------------------------------------- On Dec. 20, 2014, 12:41 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27760/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2014, 12:41 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos-git > > > Description > ------- > > The initial design and implementation of the authenticator module interface > caused issues and was not optimal for heavy lifting setup of external > dependencies. By introducing a two fold design, this has been decoupled from > the authentication message processing. The new design also gets us back on > track to the goal of makeing SASL a soft dependency of mesos. > > > Diffs > ----- > > src/authentication/authenticator.hpp 460494a > src/authentication/cram_md5/authenticator.hpp d739a02 > src/master/master.hpp 26116af > src/master/master.cpp 0c98b51 > src/tests/cram_md5_authentication_tests.cpp a356aa1 > > Diff: https://reviews.apache.org/r/27760/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
