> On Dec. 15, 2014, 6:45 p.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, line 543
> > <https://reviews.apache.org/r/29033/diff/1/?file=791613#file791613line543>
> >
> > what about continuing if !startsWith(line, "TCP") to reduce the nesting?
Fixed as suggested.
Was thinking later on we'd do:
if (TCP) {
...
} else if (UDP) {
...
}
> On Dec. 15, 2014, 6:45 p.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/network/port_mapping.cpp, line 525
> > <https://reviews.apache.org/r/29033/diff/1/?file=791613#file791613line525>
> >
> > Can you assume the output format stable? does it depend on anything,
> > e.g., if ipv6 is enabled?
> >
> > Can you add a note here why reading `/proc/net/sockstat` is not
> > expensive.
Left a note for /proc/net/sockstat, the IPv6 counter part.
There is little documentation of this proc file (not in the proc man page). I
think it's fine since usually kernel keeps it compatibile.
In the code, warnings are reported parsing the output, but program wouldn't
abort but continue -- at least this shouldn't crash.
- Chi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29033/#review65099
-----------------------------------------------------------
On Dec. 23, 2014, 7:51 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29033/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 7:51 p.m.)
>
>
> Review request for mesos, Dominic Hamon, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> While we are still working to make RTT less expensive to get, expose total
> number of tcp connections in use and in TIME_WAIT.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 540071d
> src/slave/containerizer/isolators/network/port_mapping.hpp f1e2352
> src/slave/containerizer/isolators/network/port_mapping.cpp 2d81336
> src/slave/flags.hpp 670997d
> src/tests/port_mapping_tests.cpp eb82993
>
> Diff: https://reviews.apache.org/r/29033/diff/
>
>
> Testing
> -------
>
> expanded a test case to test PortMappingStatistics.
>
>
> Thanks,
>
> Chi Zhang
>
>
