-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
-----------------------------------------------------------
Review request for mesos and Niklas Nielsen.
Bugs: MESOS-2150
https://issues.apache.org/jira/browse/MESOS-2150
Repository: mesos-git
Description
-------
Added new --slave_ping_timeout and --max_slave_ping_timeouts flags
to mesos-master to replace the existing (still default)
SLAVE_PING_TIMEOUT (15secs) and MAX_SLAVE_PING_TIMEOUTS (5).
These can be extended if slaves are expected/allowed to be down for
longer than a minute or two.
Beware that this affects recovery from network timeouts as well as
actual slave node/process failover.
Diffs
-----
src/master/flags.hpp f5c8d2a8cc7530bc8746935af9ea90af747cc111
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/tests/fault_tolerance_tests.cpp 5763486acb6d687b50c02c01ea00e1cfbea48421
src/tests/mesos.cpp 3b98c69a604132be71a60fbbee4a47b51fe6956a
src/tests/partition_tests.cpp fea78016268b007590516798eb30ff423fd0ae58
src/tests/slave_recovery_tests.cpp cd4a398ef680b5694cb6069b8e2ca4e2c05911d1
src/tests/slave_tests.cpp c50cbc799d4793243f184f9fe628b69a020adc66
Diff: https://reviews.apache.org/r/29507/diff/
Testing
-------
Manually tested slave failover/shutdown with master using different
--slave_ping_timeout and --max_slave_ping_timeouts.
Updated unit tests to use shorter non-default values for ping timeouts.
Thanks,
Adam B
