> On Dec. 31, 2014, 6:12 a.m., Timothy Chen wrote: > > src/tests/slave_tests.cpp, line 1649 > > <https://reviews.apache.org/r/29437/diff/3/?file=804508#file804508line1649> > > > > Why settle?
I settle here to ensure that we have invoked and finished "Slave::executorLaunched" method, because this method does the actual registration timeout scheduling. Note the defer() callback in onAny() method of the launch future, in Framework::launchExecutor. Since, execution of onAny() method just enqueues, the "executorLaunched" method in ProcessManager, we would want to settle here. On Dec. 31, 2014, 6:12 a.m., Nishant Suneja wrote: > > Have you looked at all the other tests that refers to > > executor_registration_timeout, and made sure they all passed as well? > > Since timing is a pretty sensitive for mesos test, I suggest you also try > > to run all the tests on repeat (./bin/mesos-tests.sh > > --gtest_break_on_failure --gtest_repeat=100 --verbose) and make sure all > > tests still pass. Yeah.. I did that. - Nishant ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29437/#review66447 ----------------------------------------------------------- On Dec. 31, 2014, 11:57 p.m., Nishant Suneja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29437/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2014, 11:57 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-999 > https://issues.apache.org/jira/browse/MESOS-999 > > > Repository: mesos-git > > > Description > ------- > > As part of this bug fix, I have trigerred the executor registration timeout > timer after the container's future object is set, instead of starting the > timer when the container launch is still pending > > > Diffs > ----- > > src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b > src/tests/composing_containerizer_tests.cpp > 5ab5a36cadb7f8622bad0c5814e9a5fb338753ad > src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 > src/tests/slave_tests.cpp f2896a1fc4521452e29fd261a6f117372345dcfc > > Diff: https://reviews.apache.org/r/29437/diff/ > > > Testing > ------- > > Added the unit test : SlaveTest::ExecutorRegistrationTimeoutTrigger > make check succeeds. > > > Thanks, > > Nishant Suneja > >
