----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29473/#review66797 -----------------------------------------------------------
Ship it! Looks great! If nobody objects, we can commit this tomorrow. I would suggest changing the `Summary` (becomes the commit oneliner) to something more detailed, like "Added service discovery info to task and executor protobufs." (Note the past-tense, <70 char length, and ending punctuation.) - Adam B On Jan. 5, 2015, 11:43 a.m., Christos Kozyrakis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29473/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 11:43 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Dominic Hamon, Niklas > Nielsen, Timothy Chen, and Timothy St. Clair. > > > Bugs: MESOS-2150 > https://issues.apache.org/jira/browse/MESOS-2150 > > > Repository: mesos-git > > > Description > ------- > > These are the Mesos changes needed to accomodate service discovery > information for tasks (see MESOS-2150). > If the frameworks launch task with service discovery info, it is made > available through the master state.json endpoint. > > > Diffs > ----- > > include/mesos/mesos.proto 540071d > src/common/http.cpp 0d0d52f > src/common/protobuf_utils.cpp 8ab5cdd > src/master/master.cpp d6651e2 > src/messages/messages.proto 16043dd > src/tests/master_tests.cpp 7f796be > > Diff: https://reviews.apache.org/r/29473/diff/ > > > Testing > ------- > > Added TaskDiscoveryInfo to MasterTest that verifies that service discovery > info appears correctly on state.json. > Passed all existing tests (make check). > > > Thanks, > > Christos Kozyrakis > >
