----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29496/#review66823 -----------------------------------------------------------
src/examples/test_hook_module.cpp <https://reviews.apache.org/r/29496/#comment110479> I wonder if we can consolidate these strings with the ones in the test code. Have you tried to extern them from the test and grab them here? src/examples/test_hook_module.cpp <https://reviews.apache.org/r/29496/#comment110478> Mind adding a comment on what the test env decorator is doing and how you will validate it in together with masterLaunchTaskLabelDecorator and slaveRemoveExecutorHook? src/tests/hook_tests.cpp <https://reviews.apache.org/r/29496/#comment110477> Test comment please :-) Also, it is a bit hard following what's going on. Can you add some comments to the test body too? src/tests/hook_tests.cpp <https://reviews.apache.org/r/29496/#comment110480> I am not sure I understand why you are doing this. Can you expand a little bit? src/tests/hook_tests.cpp <https://reviews.apache.org/r/29496/#comment110476> Same here - Niklas Nielsen On Jan. 5, 2015, 2:42 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29496/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 2:42 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-2060 > https://issues.apache.org/jira/browse/MESOS-2060 > > > Repository: mesos-git > > > Description > ------- > > This module provides hooks for master label decorator, slave executor > environment decorator and slave remove executor. A couple of test cases are > also provided to verify the hooks from this module. > > > Diffs > ----- > > src/Makefile.am 0521f5849acc3237a8fa3970c983beab74441586 > src/examples/test_hook_module.cpp PRE-CREATION > src/tests/hook_tests.cpp PRE-CREATION > src/tests/module.hpp bc1a37df7f95e945363418429fef4d090907c73a > src/tests/module.cpp 6cec1cbafe4750cff005191c51ce7c08149c18f4 > > Diff: https://reviews.apache.org/r/29496/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
