----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29598/#review66932 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/29598/#comment110660> I think having a description of what a Library is will be better. Technically Modules is actually a collection of libraries, where each library contains a collection of modules. - Timothy Chen On Jan. 6, 2015, 10:39 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29598/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 10:39 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos-git > > > Description > ------- > > [1/9] Build Mesos Modules outside Mesos source tree. > > To expose Modules message outside the mesos source tree. This allows modules > to #include mesos/mesos.hpp and get the required protobuf definition. > > > Diffs > ----- > > include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 > src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 > src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000 > src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b > src/module/manager.hpp 04c0b18df6ba820f6bba9fff00fa304d300140c5 > > Diff: https://reviews.apache.org/r/29598/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
