-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
-----------------------------------------------------------
(Updated Jan. 8, 2015, 12:44 a.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
Responding to review feedback.
Bugs: MESOS-2110
https://issues.apache.org/jira/browse/MESOS-2110
Repository: mesos-git
Description
-------
Added new --slave_ping_timeout and --max_slave_ping_timeouts flags
to mesos-master to replace the existing (still default)
SLAVE_PING_TIMEOUT (15secs) and MAX_SLAVE_PING_TIMEOUTS (5).
These can be extended if slaves are expected/allowed to be down for
longer than a minute or two.
Beware that this affects recovery from network timeouts as well as
actual slave node/process failover.
Diffs (updated)
-----
src/master/constants.hpp c386eab
src/master/constants.cpp 9ee17e9
src/master/flags.hpp f5c8d2a
src/master/master.cpp d6651e2
src/slave/constants.hpp fd1c1ab
src/slave/constants.cpp 2a99b11
src/slave/slave.cpp 50b5781
src/tests/fault_tolerance_tests.cpp 5763486
src/tests/partition_tests.cpp fea7801
src/tests/slave_recovery_tests.cpp cd4a398
src/tests/slave_tests.cpp c50cbc7
Diff: https://reviews.apache.org/r/29507/diff/
Testing
-------
Manually tested slave failover/shutdown with master using different
--slave_ping_timeout and --max_slave_ping_timeouts.
Updated unit tests to use shorter non-default values for ping timeouts.
Thanks,
Adam B
