> On Jan. 7, 2015, 10:56 a.m., Till Toenshoff wrote: > > src/slave/containerizer/isolators/cgroups/cpushare.hpp, line 26 > > <https://reviews.apache.org/r/29597/diff/1/?file=807120#file807120line26> > > > > Alphabetize please.
The other files are in a sub-directory, so I believe they should go after flags.hpp. This is the convention we follow, for example, when including `process/*` and `process/*/*hpp`. > On Jan. 7, 2015, 10:56 a.m., Till Toenshoff wrote: > > src/slave/containerizer/isolators/cgroups/mem.hpp, line 24 > > <https://reviews.apache.org/r/29597/diff/1/?file=807121#file807121line24> > > > > Alphabetize please. Same as above :-). > On Jan. 7, 2015, 10:56 a.m., Till Toenshoff wrote: > > src/slave/containerizer/isolators/cgroups/perf_event.hpp, line 30 > > <https://reviews.apache.org/r/29597/diff/1/?file=807122#file807122line30> > > > > See above ;) See above ;) > On Jan. 7, 2015, 10:56 a.m., Till Toenshoff wrote: > > src/slave/containerizer/isolators/filesystem/shared.hpp, line 22 > > <https://reviews.apache.org/r/29597/diff/1/?file=807123#file807123line22> > > > > :) See above :) > On Jan. 7, 2015, 10:56 a.m., Till Toenshoff wrote: > > src/slave/containerizer/isolators/namespaces/pid.hpp, line 22 > > <https://reviews.apache.org/r/29597/diff/1/?file=807124#file807124line22> > > > > :) See above :) > On Jan. 7, 2015, 10:56 a.m., Till Toenshoff wrote: > > src/slave/containerizer/isolators/posix.hpp, line 30 > > <https://reviews.apache.org/r/29597/diff/1/?file=807125#file807125line30> > > > > :) See above :) - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29597/#review67028 ----------------------------------------------------------- On Jan. 9, 2015, 5:46 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29597/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 5:46 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Repository: mesos-git > > > Description > ------- > > Slave flags are not being used in isolator.hpp. Removed #include > slave/flags.hpp > from isolator.hpp and included it directly in only those files that need it. > > > Diffs > ----- > > src/slave/containerizer/isolator.hpp > e82a14201f734292a46b8816c894fa8c766dae5a > src/slave/containerizer/isolators/cgroups/cpushare.hpp > 4ded0c4678ad61742a69e14233006a448f3fc3ca > src/slave/containerizer/isolators/cgroups/mem.hpp > 2fa755571b4d21b8b13301fcfd57ae05ea66e6e6 > src/slave/containerizer/isolators/cgroups/perf_event.hpp > e511c3efe4cc4ec13cc74bdcda993477a4db2e36 > src/slave/containerizer/isolators/filesystem/shared.hpp > 727f63e16fa69293c472a4b6b95fb0be04e689c8 > src/slave/containerizer/isolators/namespaces/pid.hpp > 8da6cccff04edf11fa37f5a33648821299cf49d5 > src/slave/containerizer/isolators/posix.hpp > 7a667e3e30712b98484947520b58965d3b768659 > > Diff: https://reviews.apache.org/r/29597/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
