----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29785/#review67698 -----------------------------------------------------------
Ship it! include/mesos/mesos.proto <https://reviews.apache.org/r/29785/#comment111783> 'Accept' is defined in scheduler.proto. Maybe move this comments to scheudler.proto and have a link here? It's a little confusing here without knowing what "Accept" means. include/mesos/mesos.proto <https://reviews.apache.org/r/29785/#comment111784> since offer_ids is an Array, probably use: offer_ids: [...] - Jie Yu On Jan. 12, 2015, 8:40 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29785/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 8:40 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Michael Park, and > Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > In order to support performing operations against offers (e.g. reserving / > unreserving resources, creating / destroying volumes), this introduces the > notion of an Accept Call, complementary to Decline. > > Launch becomes an alias to an Accept with LaunchTask(s) operations. > > Please take the time to look over this and share your thoughts! > > > Diffs > ----- > > include/mesos/mesos.proto 6c9f5d351bf7befc0a4956d0176018c80d96418d > include/mesos/scheduler/scheduler.proto > 5491c59e7addda0ee5d95a019d7eaeb953ca82e4 > > Diff: https://reviews.apache.org/r/29785/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
