----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29782/#review67916 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/29782/#comment112003> Let's just use namespace mesos::slave::state and we can simpify all of this. src/slave/state.cpp <https://reviews.apache.org/r/29782/#comment112002> Let's remove the extra space while you're touching - Timothy Chen On Jan. 13, 2015, 7:07 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29782/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 7:07 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos-git > > > Description > ------- > > [5/10] Build Mesos Modules outside Mesos source tree. > > This prepares src/slave/state.hpp to be exposed as a > public header include/mesos/slave/state.hpp. This > also prepares us to expose src/slave/containerizer/isolator.hpp > as include/mesos/slave/isolator.hpp. > > > Diffs > ----- > > src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443 > src/slave/containerizer/composing.hpp > f1e60b0dae45757f3573c81a4a4a2de6fcb27aca > src/slave/containerizer/composing.cpp > a6ae817a973d49b433519beb8eda99692c203613 > src/slave/containerizer/containerizer.hpp > 129e60f20835f5d151701e934330b81825887af1 > src/slave/containerizer/docker.hpp b7bf54ac65d6c61622e485ac253513eaac2e4f88 > src/slave/containerizer/docker.cpp 5f4b4ce49a9523e4743e5c79da4050e6f9e29ed7 > src/slave/containerizer/external_containerizer.hpp > 8363cec490a2918e08a8d30d9b8832fd1e2dd4f5 > src/slave/containerizer/external_containerizer.cpp > efbc68f205b26cff58bc414427d3361711afcc94 > src/slave/containerizer/isolator.hpp > a27c3e955ff25b87599af0ac2c97427a88b786f6 > src/slave/containerizer/isolator.cpp > 90a47c4fc8ce2d1a2aa09fa9ad905b76eab74c80 > src/slave/containerizer/isolators/cgroups/cpushare.hpp > 4ded0c4678ad61742a69e14233006a448f3fc3ca > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 90aabb85da452a3a508888f738379a73b7465dc6 > src/slave/containerizer/isolators/cgroups/mem.hpp > 2fa755571b4d21b8b13301fcfd57ae05ea66e6e6 > src/slave/containerizer/isolators/cgroups/mem.cpp > 711d66d7771cac13be831d73af3ef570d6785473 > src/slave/containerizer/isolators/cgroups/perf_event.hpp > e511c3efe4cc4ec13cc74bdcda993477a4db2e36 > src/slave/containerizer/isolators/cgroups/perf_event.cpp > 6f67164d3963769148fb1749d1d590b7b2999fdb > src/slave/containerizer/isolators/filesystem/shared.hpp > 727f63e16fa69293c472a4b6b95fb0be04e689c8 > src/slave/containerizer/isolators/filesystem/shared.cpp > 5c347af803bf512698dd580d6533c0103b289427 > src/slave/containerizer/isolators/namespaces/pid.hpp > 8da6cccff04edf11fa37f5a33648821299cf49d5 > src/slave/containerizer/isolators/namespaces/pid.cpp > fdd430e946c386e37ffc5b24907063180cddac17 > src/slave/containerizer/isolators/network/port_mapping.hpp > f1e23526bc18b23f187c5d38e63d366cb509fff0 > src/slave/containerizer/isolators/network/port_mapping.cpp > 2d813369bd844ad743f7d3f18dbab29b2467f2c8 > src/slave/containerizer/isolators/posix.hpp > 7a667e3e30712b98484947520b58965d3b768659 > src/slave/containerizer/launcher.hpp > 18b3546a5e51e8a3819bca11630f699a0aadf762 > src/slave/containerizer/launcher.cpp > 92c0657728ddb9f6a4f9065ff8a7093c5371bc6f > src/slave/containerizer/linux_launcher.hpp > 3d9794dd4983ecf59833f3971cbb094d4bf7710f > src/slave/containerizer/linux_launcher.cpp > 10c12039cf684bef9398da72c3eceb9ed8b8b9c9 > src/slave/containerizer/mesos/containerizer.hpp > 802988c90ac872b0cefa5e28f06e6fec98e8d032 > src/slave/containerizer/mesos/containerizer.cpp > 0bcf5ce7cfab470cabd3af3535344d19cb33b1c8 > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp b234f5359a91a293b93f97f035b08ef0a4c9b20d > src/slave/state.hpp 70777cf6ab681c29ca4df601fe47903e1dbdf41f > src/slave/state.cpp a36fa53099300ee03f051b0f5eaaafe9f1da68d1 > src/slave/status_update_manager.hpp > 1c8a54ea510de084c0f35016e83788d441d3b813 > src/slave/status_update_manager.cpp > fab8c22d46b8ab0a3c3745541ddc650b574bfbd4 > src/tests/authentication_tests.cpp 5cf2da4602edbf7c168351d5f581aca10591d5d0 > src/tests/cluster.hpp 74cedb324949143fd1949082d8a4db596a32d95c > src/tests/composing_containerizer_tests.cpp > 5ab5a36cadb7f8622bad0c5814e9a5fb338753ad > src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 > src/tests/containerizer_tests.cpp cfe31a6b528ec44c5f4ff9eaf453c68d9e518db4 > src/tests/credentials_tests.cpp 5878e57650a78777933d6df156df3c12bcfeafb5 > src/tests/docker_containerizer_tests.cpp > 2105ae2c410f01e7e0d10241d5c00df143fd3439 > src/tests/external_containerizer_test.cpp > 45cdeb57dd5b7b20294ebdecfd091a77e86941cb > src/tests/fault_tolerance_tests.cpp > 5763486acb6d687b50c02c01ea00e1cfbea48421 > src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7 > src/tests/gc_tests.cpp 454f0974833ad5db8b504a36b010cc72c3a19751 > src/tests/health_check_tests.cpp 7278f07ee73fe94eff78b6463b7dd55fb7d80584 > src/tests/isolator.hpp 2c3a694fade996df6fb679e78f96876a7d32d214 > src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 > src/tests/master_allocator_tests.cpp > 0e2e5b551ce026d630fe8f9ebf85c71384d8f43f > src/tests/master_authorization_tests.cpp > 42ffe24685b859fb16132d22a932f6637fe9b5c3 > src/tests/master_contender_detector_tests.cpp > d847a30d21b2a2980c6b7ceb62bbf61dc77487de > src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed > src/tests/mesos.cpp 3b98c69a604132be71a60fbbee4a47b51fe6956a > src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732 > src/tests/partition_tests.cpp fea78016268b007590516798eb30ff423fd0ae58 > src/tests/port_mapping_tests.cpp d57d3e6cc3b457e7c36c9bc608da5479ee9dbbca > src/tests/reconciliation_tests.cpp c21f4cba76c83ad76452cea1c28f2c6c33fca446 > src/tests/resource_offers_tests.cpp > d098e7016ac0da7f1d629af099bb1b8fa66da839 > src/tests/slave_recovery_tests.cpp 809822e63b05a21418cd9297c927d656d6fd871d > src/tests/slave_tests.cpp a85a0282947278ce6e02e38093f8b88af4cb612a > src/tests/status_update_manager_tests.cpp > 6ff732020d17d5339c8f03412c3b00a2c2ca8357 > > Diff: https://reviews.apache.org/r/29782/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >
