----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29870/#review67983 -----------------------------------------------------------
Patch looks great! Reviews applied: [29870] All tests passed. - Mesos ReviewBot On Jan. 13, 2015, 11:42 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29870/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 11:42 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Supported accept offers in C++ scheduler driver. I removed a few checks in > the new API for LAUNCH because those checks are already done in master. > > > Diffs > ----- > > src/sched/sched.cpp 5fee06e3e306c6d8eea6f2efec8b7522b7498e4a > src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e > > Diff: https://reviews.apache.org/r/29870/diff/ > > > Testing > ------- > > will add tests to test accept offers later. Sadly, we don't have unit tests > for scheduler drivers. > > make check passed > > > Thanks, > > Jie Yu > >
