> On Jan. 12, 2015, 11:34 p.m., Ben Mahler wrote: > > Could you pause the clock in these tests? That might help you test that the > > interval is respected (if you want to add a test for that).
Added a TODO. Pausing the clock is problematic for subprocess related tests. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29689/#review67745 ----------------------------------------------------------- On Jan. 12, 2015, 6:47 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29689/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 6:47 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes. > > > Bugs: MESOS-1588 > https://issues.apache.org/jira/browse/MESOS-1588 > > > Repository: mesos-git > > > Description > ------- > > Added tests for verifying DiskUsageChecker. > > > Diffs > ----- > > src/Makefile.am fc0c3227466ccf364353a739fec8d9532ea3c683 > src/tests/disk_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29689/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
