----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29903/#review68216 -----------------------------------------------------------
Ship it! src/slave/monitor.hpp <https://reviews.apache.org/r/29903/#comment112362> Maybe we should be more explicit about what we collect? How about something like Resourceusagecollector? - Alexander Rukletsov On Jan. 15, 2015, 12:55 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29903/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 12:55 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2219 > https://issues.apache.org/jira/browse/MESOS-2219 > > > Repository: mesos-git > > > Description > ------- > > Moved ResourceMonitor behind a 'Collector' abstraction. > This is the first steps towards pluggable resource monitoring. > > > Diffs > ----- > > src/slave/monitor.hpp 02b2ce1619c87296ee8c90f6363e77d070dd598d > > Diff: https://reviews.apache.org/r/29903/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
