> On Jan. 16, 2015, 12:42 a.m., Ben Mahler wrote: > > src/slave/containerizer/isolators/posix/disk.hpp, lines 22-30 > > <https://reviews.apache.org/r/29688/diff/6/?file=821620#file821620line22> > > > > Do you want future, option, and resources included? > > Jie Yu wrote: > Those are part of the IsolatorProcess interfaces (which must have been > defined in isolator.hpp). So I do not include them here.
I thought so, and that sounds fine, but FWIW I don't think we've been relying on transitive includes at all as they are prone to drift. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29688/#review68314 ----------------------------------------------------------- On Jan. 14, 2015, 8:28 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29688/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 8:28 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes. > > > Bugs: MESOS-1588 > https://issues.apache.org/jira/browse/MESOS-1588 > > > Repository: mesos-git > > > Description > ------- > > Added DiskQuotaIsolator to enforce disk quota. I created a DiskUsageChecker > to check disk usage by calling 'du'. The DiskUsageChecker is throttled (see > comments). The isolator uses DiskUsageChecker to enforce disk quota. > > > Diffs > ----- > > src/Makefile.am fc0c3227466ccf364353a739fec8d9532ea3c683 > src/slave/containerizer/isolators/posix/disk.hpp PRE-CREATION > src/slave/containerizer/isolators/posix/disk.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp > 0bcf5ce7cfab470cabd3af3535344d19cb33b1c8 > src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6 > > Diff: https://reviews.apache.org/r/29688/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
