> On Jan. 16, 2015, 12:56 a.m., Ben Mahler wrote: > > src/slave/flags.hpp, line 391 > > <https://reviews.apache.org/r/29896/diff/1/?file=821635#file821635line391> > > > > Could you document that this is relevant only for the "posix/disk" > > isolator?
Added. > On Jan. 16, 2015, 12:56 a.m., Ben Mahler wrote: > > src/tests/disk_quota_tests.cpp, line 216 > > <https://reviews.apache.org/r/29896/diff/1/?file=821636#file821636line216> > > > > Whoops, this should be false, right? > > > > The fact that this test passed means it doesn't catch the kill of the > > task. Too bad we can't pause the clock! > > > > Maybe you need a small sleep here with a TODO? Or a way to capture the > > `_monitor` dispatch? Refine the test. It should be able to catch the kill of the task. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29896/#review68376 ----------------------------------------------------------- On Jan. 14, 2015, 8:53 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29896/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 8:53 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-1588 > https://issues.apache.org/jira/browse/MESOS-1588 > > > Repository: mesos-git > > > Description > ------- > > Added a slave flag to turn off disk quota enforcement. > > > Diffs > ----- > > src/slave/containerizer/isolators/posix/disk.cpp PRE-CREATION > src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6 > src/tests/disk_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29896/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
