----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30002/#review68541 -----------------------------------------------------------
Patch looks great! Reviews applied: [29327, 29328, 29329, 29330, 29331, 29332, 29333, 29334, 29335, 29336, 29337, 29338, 29339, 29340, 29341, 30001, 30002] All tests passed. - Mesos ReviewBot On Jan. 17, 2015, 1:43 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30002/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2015, 1:43 a.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Repository: mesos-git > > > Description > ------- > > Fix docker tests and warnings running in verbose logging. > > Some of the docker tests verifies that the container output is written to > stdout/stderr based on set command and image. > As we moved the docker container execution to the executor, with verbose > logging turned out the log actually logs out the docker run command which > also will contain expected text from the output. > > Therefore, the unit tests are instead matching expected text with an exact > line as it expects the output is echoed with a new line. > > Also fixed warning about glog and making stop virtual so the expect_call > works. > > > Diffs > ----- > > src/docker/docker.hpp 3ebbc1f82ac388c4d348417ae33ccc2a56ad3f28 > src/docker/executor.cpp PRE-CREATION > src/tests/docker_containerizer_tests.cpp > 2105ae2c410f01e7e0d10241d5c00df143fd3439 > > Diff: https://reviews.apache.org/r/30002/diff/ > > > Testing > ------- > > make check gtest_repeat=-1 and gtest_shuffle > > > Thanks, > > Timothy Chen > >
