----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30039/#review68959 -----------------------------------------------------------
src/launcher/fetcher.cpp <https://reviews.apache.org/r/30039/#comment113505> Curly brace on the previous line src/launcher/fetcher.cpp <https://reviews.apache.org/r/30039/#comment113507> Curly brace on previous line src/launcher/fetcher.cpp <https://reviews.apache.org/r/30039/#comment113508> I think we need to be consistent where the log messages go, this should go into the fetchDirectlyIntoWorkDirectory so any other calls of the method will also get logged. - Timothy Chen On Jan. 21, 2015, 10:18 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30039/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 10:18 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and > Timothy Chen. > > > Bugs: MESOS-2069 > https://issues.apache.org/jira/browse/MESOS-2069 > > > Repository: mesos-git > > > Description > ------- > > Enables the fetcher cache actions prepared in the preceding patches by > implementing them in the mesos fetcher program. Also general cleanup of this > file, which is necessary to reduce complexity in and better understand the > resulting source code. > > > Diffs > ----- > > src/launcher/fetcher.cpp fed0105946da579a38357a30e7ae56e646e05b89 > > Diff: https://reviews.apache.org/r/30039/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bernd Mathiske > >
