> On Jan. 21, 2015, 8:31 p.m., Cody Maloney wrote: > > Would it be possible to get a patch which adds pragma once checking to > > cpplint (Also gives a baseline to go against for converting header include > > guards across). > > Dominic Hamon wrote: > we'd need to do that after the mass change, right?
Yes for committing it, but I think it should be a precondition that the work is done before we switch. Demonstrate we can enforce the new / changed rule. - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30100/#review68995 ----------------------------------------------------------- On Jan. 20, 2015, 11:58 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30100/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 11:58 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Cody > Maloney, Dominic Hamon, Michael Park, Niklas Nielsen, Till Toenshoff, and > Timothy Chen. > > > Bugs: MESOS-2211 > https://issues.apache.org/jira/browse/MESOS-2211 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/mesos-c++-style-guide.md 3cc9ecd3d8561840d74a6e46a3dbdedf932fec00 > > Diff: https://reviews.apache.org/r/30100/diff/ > > > Testing > ------- > > Tested with a markdown viewer. > > > Thanks, > > Kapil Arya > >
