----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30092/#review69026 -----------------------------------------------------------
src/slave/flags.hpp <https://reviews.apache.org/r/30092/#comment113593> It seems nice to have "module" within the flag name, to make this very explicit that when people set this flag, they are using potentially using external code! How about: `--resource_monitor_module`? For a help string, we might want to be more explicit as well, and warn about the fact that the HTTP API might break! ``` Specifies the resource monitoring module to use for monitoring containers. If unset, the slave will use the default resource monitor that keeps history and exposes monitoring data over HTTP endpoints. NOTE: Changing this value may break the HTTP API for container resource statistics! ``` Thoughts? Would really love to see "module" in the name of each module flag! Module use should be very explicit. - Ben Mahler On Jan. 20, 2015, 9:38 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30092/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 9:38 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2219 > https://issues.apache.org/jira/browse/MESOS-2219 > > > Repository: mesos-git > > > Description > ------- > > Adds resource_monitor to mesos-slave and change the slave process to use a > provided resource monitor implementation. > > > Diffs > ----- > > src/slave/flags.hpp 33a0cb639cd85ce4e03bd4ceaa3fed0834c239b9 > src/slave/main.cpp 42e46c58ab4b16033ac6a73d127968d0803490aa > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 > > Diff: https://reviews.apache.org/r/30092/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
