----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30143/#review69050 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/30143/#comment113619> Could you please make the style consistent? I would suggest using the following style: ``` Try<int> fd = os::open( path, O_CREAT | O_WRONLY, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); ``` Here, and everywhere else. - Jie Yu On Jan. 21, 2015, 10:25 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30143/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 10:25 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-2240 > https://issues.apache.org/jira/browse/MESOS-2240 > > > Repository: mesos-git > > > Description > ------- > > stout: Narrow down permissions on file creation through os::open. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > 80578e2207d5436a4414f56417a0fee06ca9a7e9 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 0446f6a5d5628f8566d4cbaf33dee29b52c3c42e > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > ff494c3da35a44ada703fa3997d89b4237495ef9 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 3033b7d857592c89fdb7cd2d702eb0c74e7d5647 > > Diff: https://reviews.apache.org/r/30143/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
