These new review titles make my inbox a lot cleaner! The 1/8 naming tends to be problematic though because a denominator change causes a lot of churn, and follow ups can't add to the divisor without the denominator being wrong :)
On Wed, Jan 21, 2015 at 3:03 PM, Niklas Nielsen <[email protected]> wrote: > > > > On Jan. 21, 2015, 1:11 p.m., Ben Mahler wrote: > > > src/Makefile.am, line 1251 > > > < > https://reviews.apache.org/r/30089/diff/1/?file=827305#file827305line1251> > > > > > > This file doesn't exist, should this patch depend on something? > > > > Niklas Nielsen wrote: > > Sorry - should have marked the patches as strongly dependent on each > other. All 8 patches need to go in atomically. > > I have renamed the chain to indicate this (based on your suggestion > in r30090) > > > > Ben Mahler wrote: > > Is there a reason why these makefile changes can't be included > alongside the patches that affect these files? Would really prefer the > appropriate Makefile changes to be in the appropriate patches. It's a good > exercise in rebasing too! :) > > Will do the git rebase gymnastics :) Stay tuned > > > - Niklas > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30089/#review69008 > ----------------------------------------------------------- > > > On Jan. 21, 2015, 2:36 p.m., Niklas Nielsen wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/30089/ > > ----------------------------------------------------------- > > > > (Updated Jan. 21, 2015, 2:36 p.m.) > > > > > > Review request for mesos and Ben Mahler. > > > > > > Bugs: MESOS-2219 > > https://issues.apache.org/jira/browse/MESOS-2219 > > > > > > Repository: mesos-git > > > > > > Description > > ------- > > > > Adds new monitor interface, mesos monitor and monitor module sources to > make file. > > > > > > Diffs > > ----- > > > > src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e > > > > Diff: https://reviews.apache.org/r/30089/diff/ > > > > > > Testing > > ------- > > > > bootstrapping, running configure and make check > > > > > > Thanks, > > > > Niklas Nielsen > > > > > >
