> On Jan. 21, 2015, 12:12 p.m., Timothy Chen wrote: > > src/slave/containerizer/fetcher.cpp, line 58 > > <https://reviews.apache.org/r/30124/diff/1/?file=828472#file828472line58> > > > > Planning to add some tests? :)
Tests come in MESOS-2074, which is up next. Adding a TODO in fetcher.hpp. > On Jan. 21, 2015, 12:12 p.m., Timothy Chen wrote: > > src/slave/slave.cpp, line 790 > > <https://reviews.apache.org/r/30124/diff/1/?file=828473#file828473line790> > > > > Who's going to re-create the cache directory from this point? It gets created on demand when the first attempt to cache happens. Since "clearCache" does not directly imply deleting a dir, even though this is how it is currently implemented, I refrain from putting a comment mentioning dir creation right here. - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30124/#review68993 ----------------------------------------------------------- On Jan. 21, 2015, 9:16 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30124/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 9:16 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and > Timothy Chen. > > > Bugs: MESOS-2070 > https://issues.apache.org/jira/browse/MESOS-2070 > > > Repository: mesos-git > > > Description > ------- > > Removes the slave ID-specific fetcher cache directory (with its contents) on > slave startup, recovery and shutdown. > > > Diffs > ----- > > src/slave/containerizer/fetcher.hpp > 1db0eaf002c8d0eaf4e0391858e61e0912b35829 > src/slave/containerizer/fetcher.cpp > 5993670f7899233efa1e6acef4b0c7856e32f748 > src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 > > Diff: https://reviews.apache.org/r/30124/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bernd Mathiske > >
