----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29528/#review69239 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/29528/#comment113884> A list would be great to get a quick overview of the special powers of 'size' ;) Size value Meaning Absent Read as much as possible < 0 Read until EOF = 0 What happens here? > 0 Read until N bytes has been read 3rdparty/libprocess/src/socket.cpp <https://reviews.apache.org/r/29528/#comment113871> Can we every have an index that exceededs the original data size? Probably not, but continueing sending wouldn't make much sense either. We could guard against this by changing the test to 'index >= data->size())' or throw an error if index is strictly larger. Feel free to drop is you have strong guarantees that this will never happen. - Niklas Nielsen On Jan. 21, 2015, 9:42 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29528/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 9:42 a.m.) > > > Review request for mesos, Joris Van Remoortere and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > ddb9e365fc1e65a568bdac4973964df1ab8cc05e > 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f > > Diff: https://reviews.apache.org/r/29528/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
