----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29538/#review69265 -----------------------------------------------------------
LGTM but fundamentally, it seems like we do not have consensus on this change. Awaiting feedback on the dev@ thread before giving ship-it - Niklas Nielsen On Jan. 21, 2015, 9:49 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29538/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 9:49 a.m.) > > > Review request for mesos, Dominic Hamon, Evelina Dumitrescu, Joris Van > Remoortere, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am > 542ae1c39283087da6fef69be29c811ac35f00f4 > 3rdparty/libprocess/include/process/address.hpp PRE-CREATION > 3rdparty/libprocess/include/process/future.hpp > 0326b23cdd475c6e86b33f9b4c63136fdecab443 > 3rdparty/libprocess/include/process/network.hpp PRE-CREATION > 3rdparty/libprocess/include/process/node.hpp > 173eb8abe0d0930c92f261be7a95e07b1d4c16af > 3rdparty/libprocess/include/process/pid.hpp > 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22 > 3rdparty/libprocess/include/process/process.hpp > 3708f98b8fb6737aafb1c058122a8cd01885b76d > 3rdparty/libprocess/include/process/socket.hpp > ddb9e365fc1e65a568bdac4973964df1ab8cc05e > 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 > 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d > 3rdparty/libprocess/src/poll_socket.hpp > f7ca08e04f0e2a6c4436579b8e18881376985aa5 > 3rdparty/libprocess/src/poll_socket.cpp > 2e70c6c43a9474c577f7fe409c3722290f247d6c > 3rdparty/libprocess/src/process.cpp > 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf > 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f > 3rdparty/libprocess/src/tests/benchmarks.cpp > b286259afd5bd4b3ff47e04d754e675e2db0e6d1 > 3rdparty/libprocess/src/tests/http_tests.cpp > c71a91d516214d20d3df4c220e4a39a070db3260 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 0c80c69bc3457fd70ab745ff8a02be6ec9cfd9e7 > 3rdparty/libprocess/src/tests/process_tests.cpp > 3bbfe0a7a65acb52d139fda81816acf305d891f5 > > Diff: https://reviews.apache.org/r/29538/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
