-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30194/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ken Sipe.
Bugs: mesos-1806
https://issues.apache.org/jira/browse/mesos-1806
Repository: mesos-git
Description
-------
One behavioral change: --foo=/asdf where /asdf is an absolute path and
foo is backed by JSON is no longer accepted.
More cases kept being added which dealt with 'file://' urls, parsing
them, reading from the file, and then handling the argument as though
the file:// wasn't there.
We now always read an argument from a file in the argument parser if
it begins with 'file://'. If you want to pass an argument which is a
filename, then just use the path directly.
>From a quick pass on JIRA (first page of results in JIRA searching for files):
This would have prevented: MESOS-1368, MESOS-1635, MESOS-1590
And simplifies supporting: MESOS-1868
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
f4b7a95a8ca1e625c3dac7823f4db47f7b4f2c10
3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp
120946909cd19653ae5f71d401b5c9ea6d8228cd
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
3b60ff824bada441cd657e10ca01762085a6d099
Diff: https://reviews.apache.org/r/30194/diff/
Testing
-------
Thanks,
Cody Maloney
