----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29569/#review69287 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/once.hpp <https://reviews.apache.org/r/29569/#comment113930> if (started && !finished) ? Probably a noop, but for clarity. - Niklas Nielsen On Jan. 21, 2015, 9:57 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29569/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 9:57 a.m.) > > > Review request for mesos, Joris Van Remoortere and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > The original once abstraction was implemented using promises, which made it > unusable to initialize libprocess because libprocess must be initialized in > order to use a Promise. This removes that requirement, but it also means that > an actor blocking on a Once will no longer donate it's thread while it's > waiting (since it doesn't wait on a Promise, which waits on a Latch, which > waits on a ProcessBase, which donates the thread while waiting). > > > Diffs > ----- > > 3rdparty/libprocess/include/process/once.hpp > e85b38205065b34d438f68a6441905eb2f90169c > > Diff: https://reviews.apache.org/r/29569/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
