----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29541/#review69314 -----------------------------------------------------------
3rdparty/libprocess/include/process/network.hpp <https://reviews.apache.org/r/29541/#comment113971> These can both be const. 3rdparty/libprocess/include/process/network.hpp <https://reviews.apache.org/r/29541/#comment113972> We could add a comment here that in c++11 we can replace this with addresses.emplace_back(ip, port); 3rdparty/libprocess/include/process/network.hpp <https://reviews.apache.org/r/29541/#comment113973> same comment as in 29538. 3rdparty/libprocess/include/process/network.hpp <https://reviews.apache.org/r/29541/#comment113974> This will actually fall through to the default and return an error. Can we put scope braces around the case, and add a break statement? 3rdparty/libprocess/include/process/network.hpp <https://reviews.apache.org/r/29541/#comment113976> I think we can use a comment here that getnameinfo sets the hostname and service name to be null-terminated so we don't have to memset the char array? - Joris Van Remoortere On Jan. 21, 2015, 5:56 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29541/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 5:56 p.m.) > > > Review request for mesos, Dominic Hamon, Evelina Dumitrescu, Joris Van > Remoortere, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/network.hpp PRE-CREATION > 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 > 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d > 3rdparty/libprocess/src/process.cpp > 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf > > Diff: https://reviews.apache.org/r/29541/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
