----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29533/#review69367 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp <https://reviews.apache.org/r/29533/#comment114060> In the usage this isn't a storage format, it's just a convenient form to manipulate a URL in then have it turned into either a URI string (http://...) or HTTP Request headers. The etcd code which is using this for instance will take a URL then manipulate the query string in order to add additional parameters, which would be really complicated to do with either specialized member functions or by copying with a slight mutation member by member. 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp <https://reviews.apache.org/r/29533/#comment114061> This is actually incorrect URL encoding if key or value contain '&' (which is legal). See the long thread in https://reviews.apache.org/r/28253/ - Cody Maloney On Jan. 21, 2015, 5:44 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29533/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 5:44 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 8e51957d141af0be64cac42f65e03bca5929c8a9 > 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/url_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29533/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
