> On Jan. 23, 2015, 1:50 a.m., Niklas Nielsen wrote:
> > src/Makefile.am, lines 466-469
> > <https://reviews.apache.org/r/29925/diff/2/?file=826921#file826921line466>
> >
> > Sort alphabetically :)
This is something controversial. I greped the code and saw different approaches
to how we organize includes with nested directories. Let's take
`slave/containerizer` as an example. Makefile:
```
slave/containerizer/containerizer.cpp \
slave/containerizer/composing.cpp \
slave/containerizer/composing.hpp \
slave/containerizer/docker.cpp \
slave/containerizer/docker.hpp \
slave/containerizer/external_containerizer.cpp \
slave/containerizer/fetcher.cpp \
slave/containerizer/isolator.cpp \
slave/containerizer/isolators/posix/disk.cpp \
slave/containerizer/launcher.cpp \
slave/containerizer/mesos/containerizer.cpp \
slave/containerizer/mesos/launch.cpp \
```
versus
```
slave/containerizer/containerizer.hpp \
slave/containerizer/fetcher.hpp \
slave/containerizer/external_containerizer.hpp \
slave/containerizer/isolator.hpp \
slave/containerizer/launcher.hpp \
slave/containerizer/linux_launcher.hpp \
slave/containerizer/mesos/containerizer.hpp \
slave/containerizer/mesos/launch.hpp \
slave/containerizer/isolators/posix.hpp \
slave/containerizer/isolators/posix/disk.hpp \
slave/containerizer/isolators/cgroups/constants.hpp \
slave/containerizer/isolators/cgroups/cpushare.hpp \
slave/containerizer/isolators/cgroups/mem.hpp \
slave/containerizer/isolators/cgroups/perf_event.hpp \
slave/containerizer/isolators/namespaces/pid.hpp \
slave/containerizer/isolators/filesystem/shared.hpp \
```
Same inconsistency we have for includes, though grepping the code shows we tend
to separate includes with nested folders in path. I'll sort alphabetically
here, but I would like to know what our policy is for inlcudes and Makefile.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29925/#review69325
-----------------------------------------------------------
On Jan. 20, 2015, 6:06 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29925/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2015, 6:06 p.m.)
>
>
> Review request for mesos, Bernd Mathiske and Niklas Nielsen.
>
>
> Bugs: MESOS-2213
> https://issues.apache.org/jira/browse/MESOS-2213
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 07bea1f
> src/local/local.cpp 76e73a4
> src/master/allocation/allocator.hpp PRE-CREATION
> src/master/allocation/mesos/hierarchical.hpp PRE-CREATION
> src/master/allocation/sorter.hpp PRE-CREATION
> src/master/allocation/sorters/drf.hpp PRE-CREATION
> src/master/allocation/sorters/drf.cpp PRE-CREATION
> src/master/allocator.hpp 224569a
> src/master/drf_sorter.hpp e0ec58b
> src/master/drf_sorter.cpp 967c8aa
> src/master/hierarchical_allocator_process.hpp ccd37b4
> src/master/main.cpp e5e76ce
> src/master/master.cpp e9dcca3
> src/master/sorter.hpp 333c293
> src/tests/cluster.hpp 74cedb3
> src/tests/fault_tolerance_tests.cpp 5763486
> src/tests/hierarchical_allocator_tests.cpp 7c05123
> src/tests/master_allocator_tests.cpp 2430622
> src/tests/master_authorization_tests.cpp 42ffe24
> src/tests/master_slave_reconciliation_tests.cpp 04806ed
> src/tests/master_tests.cpp 678d27f
> src/tests/mesos.hpp 591134b
> src/tests/rate_limiting_tests.cpp 7f5ca25
> src/tests/resource_offers_tests.cpp d098e70
> src/tests/sorter_tests.cpp 56e5714
>
> Diff: https://reviews.apache.org/r/29925/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu, OS X)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
