> On Jan. 27, 2015, 8:14 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 1030
> > <https://reviews.apache.org/r/29288/diff/10/?file=836987#file836987line1030>
> >
> > Might be worth pulling this out as a constant?
>
> Evelina Dumitrescu wrote:
> that cannot be a constant
>
> Joris Van Remoortere wrote:
> To be more clear, the 512 literal can be converted to a constant, the
> same way there are constants elsewhere in this file for character buffers.
>
> Evelina Dumitrescu wrote:
> if I put const there, the compiler complaints about this.
I don't seem to have an issue when I compile:
```
static const size_t BUFFER_SIZE = 1024;
int main() {
char buffer[BUFFER_SIZE];
memset(buffer, 0, BUFFER_SIZE);
}
```
Again, I mean have a constant for the size, not make the char array const.
Does this make more sense?
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/#review69856
-----------------------------------------------------------
On Jan. 28, 2015, 3:58 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29288/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 3:58 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van
> Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4
> and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of
> container filters, but write different encode/decode functions for IPv4/ICMP
> and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
> a0210ea6440086246aafe632f86498abbb70719a
> 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp
> 425132e5d7c3770be4a5a39feea5a2f22179b871
>
> Diff: https://reviews.apache.org/r/29288/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
