----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30395/#review70231 -----------------------------------------------------------
src/master/contender.hpp <https://reviews.apache.org/r/30395/#comment115307> Let's expand the comment with etcd examples. src/master/contender.cpp <https://reviews.apache.org/r/30395/#comment115306> You can safely omit trailing underscores. - Alexander Rukletsov On Jan. 29, 2015, 3:58 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30395/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 3:58 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1806 > https://issues.apache.org/jira/browse/MESOS-1806 > > > Repository: mesos-git > > > Description > ------- > > etcd master contender + detector > > > Diffs > ----- > > src/etcd/etcd.cpp PRE-CREATION > src/master/contender.hpp 76beb5f973ae02507849233b6d73c43293669489 > src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406 > src/master/detector.hpp 2905e2b3536e14e9df3570da172603e6ed81aae1 > src/master/detector.cpp 700eb9dde8e71648bacc00a82766634f77cf2d15 > > Diff: https://reviews.apache.org/r/30395/diff/ > > > Testing > ------- > > > Thanks, > > Cody Maloney > >
