----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30402/#review70243 -----------------------------------------------------------
Ship it! src/tests/slave_tests.cpp <https://reviews.apache.org/r/30402/#comment115317> Can you add a comment here on why you do a max() here for future readers? - Vinod Kone On Jan. 29, 2015, 4:35 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30402/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 4:35 a.m.) > > > Review request for mesos, Alexander Rukletsov and Vinod Kone. > > > Bugs: MESOS-2228 > https://issues.apache.org/jira/browse/MESOS-2228 > > > Repository: mesos-git > > > Description > ------- > > This bumps the graceful shutdown to 10 seconds to attempt to reduce the > flakiness of the test. > > I also cleaned up some of the naming to consistently call it the "Command > Executor". > > > Diffs > ----- > > src/launcher/executor.cpp f00b6fcc2976b210c6213e52662f18f0d0342671 > src/tests/slave_tests.cpp aff9e255bac596a02c3d31b7c11dd5389634be20 > > Diff: https://reviews.apache.org/r/30402/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
