> On Jan. 29, 2015, 6:49 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 2929-2931 > > <https://reviews.apache.org/r/30386/diff/1/?file=839423#file839423line2929> > > > > What is this TODO? How could one create a volume that's already > > reserved?
This is if we're creating a volume with dynamically reserved regular disk. We want to transition from `[(disk, 2, role, DYNAMIC)]` to `[(disk, 2, role, DYNAMIC, persistence=id, ...)]` not to `[(disk, 2, role, DYNAMIC), (disk, 2, role, DYNAMIC, persistence=id, ...)]`. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30386/#review70144 ----------------------------------------------------------- On Jan. 29, 2015, 12:12 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30386/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 12:12 a.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Added support for CREATE operation in master. > > > Diffs > ----- > > src/master/master.hpp 1d342e56116ad63aade43484b6899ce26f25abfd > src/master/master.cpp 54f26900ac8c63e79a1f89562a988c9a2567d209 > > Diff: https://reviews.apache.org/r/30386/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
