> On Jan. 29, 2015, 1:59 p.m., Cody Maloney wrote: > > .travis.yml, line 30 > > <https://reviews.apache.org/r/30426/diff/1/?file=840481#file840481line30> > > > > --enable-debug / --enable-release don't do anything currently when > > CXXFLAGS has an initial value since linux distribution build systems > > usually set them specifically to get debug / release / optimized /etc. You > > should manually add "-g -O0". > > > > I actually thing we should add a mesos configure check for this: > > if compiler == clang && libc++ is installed: > > use libc++ > > > > Will make clang "just work" more of the times. libstdc++ has a habit > > lately of breaking clang with new releases. > > Dominic Hamon wrote: > re: configure check: sounds reasonable. > > re: enable-<build type>: that's surprising. CXXFLAGS could be set > anywhere in the system and a developer on Mesos might not realise. Perhaps we > should be firmer about what we mean by 'debug' and 'release' so we can just > set the flags. > > Cody Maloney wrote: > Re: enable-<build-type> > > The problem is how do you pass the knowledge down to stout / libprocess / > etc? They don't see the outer configure flags unfortunately. Initially I > always set the flags for --enable-optimize / --enable-debug / default, but > that resulted in builds which would get an optimized mesos but a unoptimized > libprocess + stout + misc. other tools... > > Might be able to restructure it to a "if explicitly stated then will > force append to CXXFLAGS, otherwise we only overwrite CXXFLAGS if they were > unset. But that will take some configure digging.
we should probably take this to a jira but.. if you have --enable-<build-type> in libprocess and stout, they'll pick up the flag too. it'll take some maintenance to ensure a debug libprocess is the same as a debug mesos (or at least ABI compatible) but that should 'just work'. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30426/#review70284 ----------------------------------------------------------- On Jan. 29, 2015, 1:53 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30426/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 1:53 p.m.) > > > Review request for mesos and Cody Maloney. > > > Bugs: MESOS-2304 > https://issues.apache.org/jira/browse/MESOS-2304 > > > Repository: mesos-git > > > Description > ------- > > Use libc++ for travis clang builds > > > Diffs > ----- > > .travis.yml 4991dd77a62b8bfc6045099ca99682b47aadaa97 > > Diff: https://reviews.apache.org/r/30426/diff/ > > > Testing > ------- > > > Thanks, > > Dominic Hamon > >
