----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30430/#review70292 -----------------------------------------------------------
Ship it! Thanks for testing! src/tests/resources_tests.cpp <https://reviews.apache.org/r/30430/#comment115377> Maybe s/Subset/Contains/ and we can add a normal (non-duplicate) contains test in here? - Ben Mahler On Jan. 29, 2015, 11:08 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30430/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 11:08 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Fixed a bug in Resources::contains. > > > Diffs > ----- > > src/common/resources.cpp 68f64213c47be4700bcb22cd5b76ba6ff616960d > src/tests/resources_tests.cpp 9fd2135a7545268e2f81915ed0a019de36f3d6e1 > > Diff: https://reviews.apache.org/r/30430/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jie Yu > >
