----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30459/#review70429 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/30459/#comment115610> const Offer* ? src/master/master.hpp <https://reviews.apache.org/r/30459/#comment115609> const Master*? or const Master& even. or make const versions of getOffer and getSlave that are public in the master? src/master/validation.hpp <https://reviews.apache.org/r/30459/#comment115611> these two helpers don't need to be in the header. - Dominic Hamon On Jan. 30, 2015, 2:27 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30459/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 2:27 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-2305 > https://issues.apache.org/jira/browse/MESOS-2305 > > > Repository: mesos > > > Description > ------- > > Refactored task/offer/resource valiation in master. > > See ticket for motivation. > > > Diffs > ----- > > src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e > src/master/master.hpp 337e00aa46ea127f3667e3383d631c3fb8e22f30 > src/master/master.cpp 10056861b95ed9453c971787982db7d09f09f323 > src/master/validation.hpp PRE-CREATION > src/master/validation.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/30459/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
