> On Jan. 29, 2015, 4:08 p.m., Alexander Rukletsov wrote: > > src/etcd/etcd.cpp, line 43 > > <https://reviews.apache.org/r/30394/diff/1/?file=839636#file839636line43> > > > > What is `::URL`?
It was <stout/url> which lives in the global namespace and conflicts in resolution with etcd::URL which is why I added the explicit "Get this from the global namespace". Now it's http::URL in libprocess which reads better. > On Jan. 29, 2015, 4:08 p.m., Alexander Rukletsov wrote: > > src/etcd/etcd.cpp, lines 260-265 > > <https://reviews.apache.org/r/30394/diff/1/?file=839636#file839636line260> > > > > Let's move `URL etcd_url` to a new line and allign accordingly. Also, I > > think we use camelCase everywhere, so maybe `etcdURL` is a better name. @mpark: Can you fix clang-format to do the right thing here? That is how I formatted this and it isn't the style we consistently use in `src/mesos/master.hpp` > On Jan. 29, 2015, 4:08 p.m., Alexander Rukletsov wrote: > > src/etcd/etcd.cpp, line 283 > > <https://reviews.apache.org/r/30394/diff/1/?file=839636#file839636line283> > > > > Could you please point me to `http::put()` definition? https://reviews.apache.org/r/29534/ > On Jan. 29, 2015, 4:08 p.m., Alexander Rukletsov wrote: > > src/etcd/etcd.cpp, lines 309-311 > > <https://reviews.apache.org/r/30394/diff/1/?file=839636#file839636line309> > > > > See above, where does `http::get()` live? https://reviews.apache.org/r/29534/ - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30394/#review70210 ----------------------------------------------------------- On Jan. 29, 2015, 3:58 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30394/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 3:58 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1806 > https://issues.apache.org/jira/browse/MESOS-1806 > > > Repository: mesos > > > Description > ------- > > etcd api wrapper > > > Diffs > ----- > > src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e > src/etcd/etcd.hpp PRE-CREATION > src/etcd/etcd.cpp PRE-CREATION > src/etcd/url.hpp PRE-CREATION > src/etcd/url.cpp PRE-CREATION > src/master/constants.hpp c386eab3973363e64c113f7e84452456fdd3393c > src/master/constants.cpp 9ee17e9ad884da98cabfdfe316cb4a831de193b3 > > Diff: https://reviews.apache.org/r/30394/diff/ > > > Testing > ------- > > > Thanks, > > Cody Maloney > >
