----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30531/#review70984 -----------------------------------------------------------
Ship it! src/slave/paths.cpp <https://reviews.apache.org/r/30531/#comment116466> please use const reference here const string& src/slave/paths.cpp <https://reviews.apache.org/r/30531/#comment116468> Ditto. src/slave/paths.cpp <https://reviews.apache.org/r/30531/#comment116469> Ditto. src/slave/paths.cpp <https://reviews.apache.org/r/30531/#comment116470> Ditto. - Jie Yu On Feb. 4, 2015, 5:22 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30531/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 5:22 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-2314 > https://issues.apache.org/jira/browse/MESOS-2314 > > > Repository: mesos > > > Description > ------- > > Remove strings::format and unnecessary constants from paths > > > Diffs > ----- > > src/slave/paths.hpp 4d6897f9eebcd6852f0223bae23a29729a42e750 > src/slave/paths.cpp fe951abac1254748dbd5bdd81b7e50da75afad6d > > Diff: https://reviews.apache.org/r/30531/diff/ > > > Testing > ------- > > > Thanks, > > Dominic Hamon > >
