-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30195/
-----------------------------------------------------------
(Updated Feb. 5, 2015, 10:31 p.m.)
Review request for mesos, Benjamin Hindman and Ken Sipe.
Bugs: mesos-1806
https://issues.apache.org/jira/browse/mesos-1806
Repository: mesos
Description (updated)
-------
Mostly simplifies things. There are two places where there things get
complicated
1. --whitelist: This code wants a file to watch for changes and update
the whitelist from periodically. Introduces Path to work around this.
2. --credential, --credentials: Custom parsing logic since the
credentials can be given in two different formats. Once the old
format is removed, either teaching <stout/flags> how to parse json
to protobuf generally or taking the flag as JSON then converting it
to protobuf later will make this clean.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp
9f8f52040f22f995fb8b66a4078a0149ba26cca7
CHANGELOG f515bc937441a2b4cc7e33bb857cb48a21aedea0
docs/configuration.md 22f9e3db7b0e1691018de5fe3dfea3cb908de4b9
docs/upgrades.md 51c7e70c7ddcd3d5f678872553a18eb27622f052
src/credentials/credentials.hpp 4cdadb1b6d5a607cee8caeb38f2cbf2e3ec5da7a
src/examples/load_generator_framework.cpp
01a567b424140575ae0c369d026589300f173143
src/master/contender.hpp 76beb5f973ae02507849233b6d73c43293669489
src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406
src/master/detector.hpp 2905e2b3536e14e9df3570da172603e6ed81aae1
src/master/detector.cpp 700eb9dde8e71648bacc00a82766634f77cf2d15
src/master/flags.hpp 6c18a1af625311ef149b5877b08f63c2b12c040d
src/master/main.cpp e5e76ce16646eb0244227104038efeae5fbbbb2b
src/master/master.cpp d04b2c4041d8fe8978b877f07579a6f907903e1b
src/slave/flags.hpp facf6d3e68e412897a1381d7bbdcceaf5d1fbb94
src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b
src/tests/credentials_tests.cpp 091b545c11cfa9deabf710366e15cfc0b966de0f
src/tests/master_allocator_tests.cpp 018a6ccba8bb78974de06398f423f1f30ef3a3df
src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
src/tests/mesos.cpp 5ed4df530cf1bf11eec3b29542641822e0f702b2
src/watcher/whitelist_watcher.hpp a1c1235a27512cf194cdeffc4ad7ca5ecd834f5c
src/watcher/whitelist_watcher.cpp b6e73d7f500931dec69f115e554f9cd7cb42c3ed
src/zookeeper/url.hpp 16e711c5c0bc29b1967a20f0827238f8a7b0deaf
Diff: https://reviews.apache.org/r/30195/diff/
Testing
-------
make distcheck
- Tests not hitting the file:// handling which were replaced with CHECK()
statements.
Thanks,
Cody Maloney
