----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30591/#review71367 -----------------------------------------------------------
Ship it! src/master/main.cpp <https://reviews.apache.org/r/30591/#comment117073> Did you finish this comment? Looks like you wanted to say something after the comma? src/master/main.cpp <https://reviews.apache.org/r/30591/#comment117075> = None(); src/master/main.cpp <https://reviews.apache.org/r/30591/#comment117074> Please fix indentation. src/master/main.cpp <https://reviews.apache.org/r/30591/#comment117106> For now: if (masters.isSome() && zk.isNone()) { src/master/main.cpp <https://reviews.apache.org/r/30591/#comment117081> Range based for is not supported by gcc 4.4! src/master/main.cpp <https://reviews.apache.org/r/30591/#comment117099> Let's just use network::resolve directly. src/master/main.cpp <https://reviews.apache.org/r/30591/#comment117100> s/decode/resolve/ s|hostname/ip|address| s/:/ for/ src/master/main.cpp <https://reviews.apache.org/r/30591/#comment117101> s/lookup/resolve/ s/ip/address/ src/master/main.cpp <https://reviews.apache.org/r/30591/#comment117103> uint16_t port = addresses.get()[0].port; replicas.insert(UPID("log-replica(1)", ip, port == 0 ? 5050 : port)); src/master/main.cpp <https://reviews.apache.org/r/30591/#comment117104> Newline above and below this log line pleae! src/master/main.cpp <https://reviews.apache.org/r/30591/#comment117105> s/.// - Benjamin Hindman On Feb. 4, 2015, 12:12 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30591/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 12:12 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1806 > https://issues.apache.org/jira/browse/MESOS-1806 > > > Repository: mesos > > > Description > ------- > > Adds a --masters option which is used in preference of --etcd or --zk > and automatically figures out --quorum if that flag isn't set. > > > Diffs > ----- > > src/master/main.cpp e5e76ce16646eb0244227104038efeae5fbbbb2b > > Diff: https://reviews.apache.org/r/30591/diff/ > > > Testing > ------- > > > Thanks, > > Cody Maloney > >
