----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30589/#review71390 -----------------------------------------------------------
src/master/contender.hpp <https://reviews.apache.org/r/30589/#comment117113> Alphabetical ordering please. src/master/contender.hpp <https://reviews.apache.org/r/30589/#comment117112> Two newlines between top-level function and class declarations/definitions please. src/master/contender.hpp <https://reviews.apache.org/r/30589/#comment117110> s/ &/& / src/master/contender.cpp <https://reviews.apache.org/r/30589/#comment117111> Alphabetical ordering please. src/master/contender.cpp <https://reviews.apache.org/r/30589/#comment117115> Thanks! src/master/contender.cpp <https://reviews.apache.org/r/30589/#comment117116> Thanks! src/master/contender.cpp <https://reviews.apache.org/r/30589/#comment117117> What, you don't like comments!? ;-) src/master/contender.cpp <https://reviews.apache.org/r/30589/#comment117118> This comment does not seem correct. src/master/contender.cpp <https://reviews.apache.org/r/30589/#comment117119> Why aren't we incrementing the index by 1? Comment! src/master/contender.cpp <https://reviews.apache.org/r/30589/#comment117120> Should this comment say "Looks like we were _not_ able ..."? src/master/contender.cpp <https://reviews.apache.org/r/30589/#comment117121> The comment below is much more helpful, what are you trying to say here? src/master/detector.hpp <https://reviews.apache.org/r/30589/#comment117122> Alphabetical please. src/master/detector.hpp <https://reviews.apache.org/r/30589/#comment117123> What's this about 'group session'? src/master/detector.cpp <https://reviews.apache.org/r/30589/#comment117124> This is a perfectly fine comment to use above where we're extracting fields from the node for watching as well! src/master/detector.cpp <https://reviews.apache.org/r/30589/#comment117125> s/masterInfo/MasterInfo from/ src/master/detector.cpp <https://reviews.apache.org/r/30589/#comment117126> Newline please! src/master/detector.cpp <https://reviews.apache.org/r/30589/#comment117130> No period implies incomplete comment ... looks pretty incomplete to me! ;-) src/master/detector.cpp <https://reviews.apache.org/r/30589/#comment117128> What is this line doing!? - Benjamin Hindman On Feb. 4, 2015, 12:10 a.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30589/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 12:10 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1806 > https://issues.apache.org/jira/browse/MESOS-1806 > > > Repository: mesos > > > Description > ------- > > etcd master contender + detector > > > Diffs > ----- > > src/master/contender.hpp 76beb5f973ae02507849233b6d73c43293669489 > src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406 > src/master/detector.hpp 2905e2b3536e14e9df3570da172603e6ed81aae1 > src/master/detector.cpp 700eb9dde8e71648bacc00a82766634f77cf2d15 > src/master/main.cpp e5e76ce16646eb0244227104038efeae5fbbbb2b > src/slave/main.cpp 42e46c58ab4b16033ac6a73d127968d0803490aa > > Diff: https://reviews.apache.org/r/30589/diff/ > > > Testing > ------- > > > Thanks, > > Cody Maloney > >
